[spaceship] parse response body as json if not already

[ilendemli]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

spaceship failed to parse an api-responses such as expired membership when running fastlane match. This MR checks if the respone body is an object of type String and parses the body as a JSON object if that is the case (better handling for #18431 and similar failures).

Description

updates handle_error and format_errors in Spaceshipt::ConnectAPIT::APIClient and checks wether response.body is empty or not. uses an empty object if String is empty. Then parses result as JSON if the result is tyoe of string

Testing Steps

rspec and rubocop went through as-well as bundle exec fastlane test

[max-ott]

Hi @ilendemli 👋 ,
Looks like a great PR! Do you have any tests steps for us to test this via the spaceship playground or similar? What kind of "errors" / test cases did you use besides expired membership?

[joshdholtz]

We might want to rescue an error here if it can't parse and display something somewhat user friendly 🤔 Thoughts?

[ilendemli]

I have changed this part of the code, but I am doing the same as in other places.

[ilendemli]

Hi @ilendemli 👋 ,
Looks like a great PR! Do you have any tests steps for us to test this via the spaceship playground or similar? What kind of "errors" / test cases did you use besides expired membership?

Hey @max-ott!

I traced the call:
Spaceship::ConnectAPI::Provisioning::Client sends a request by calling the request method from its superclass Spaceship::ConnectAPI::APIClient which is a subclass of Spaceship::Client. Spaceship::ConnectAPI::APIClient overrides the handle_error method but the passed object to Spaceship::Client is a String and not a JSON/Hash.

I am now doing the same as in fetch_olympus_session in Spaceship::Client#L542.

Not sure if I have missed something else.

EDIT: I don't have any steps i can give. I have projects with different teams where i changed the fastlane instance to my cloned repo and then debugged using a breakpoint and compared responses by stepping through fastlane.

[dede760]

.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[joshdholtz]

@googlebot I consent.

[joshdholtz]

Thanks for this PR! I added a little bit to it and some tests. I really appreciate the contribution ❤️

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.186.0 🚀