Skip to content

Commit

Permalink
Merge pull request #954 from fastlane/patch/fix-slack-deprecations
Browse files Browse the repository at this point in the history
Fix deprecation warnings in slack action from git_helper changes
  • Loading branch information
KrauseFx committed Dec 4, 2015
2 parents 3ed18e0 + 3ba7b0e commit e248112
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/fastlane/actions/slack.rb
Original file line number Diff line number Diff line change
Expand Up @@ -156,23 +156,23 @@ def self.generate_slack_attachments(options)
end

# git_author
if Actions.git_author && should_add_payload[:git_author]
if Actions.git_author_email && should_add_payload[:git_author]
if ENV['FASTLANE_SLACK_HIDE_AUTHOR_ON_SUCCESS'] && options[:success]
# We only show the git author if the build failed
else
slack_attachment[:fields] << {
title: 'Git Author',
value: Actions.git_author,
value: Actions.git_author_email,
short: true
}
end
end

# last_git_commit
if Actions.last_git_commit && should_add_payload[:last_git_commit]
if Actions.last_git_commit_message && should_add_payload[:last_git_commit]
slack_attachment[:fields] << {
title: 'Git Commit',
value: Actions.last_git_commit,
value: Actions.last_git_commit_message,
short: false
}
end
Expand Down

0 comments on commit e248112

Please sign in to comment.