Skip to content

Commit

Permalink
[action][github_api] remove all instances of is_string in options a…
Browse files Browse the repository at this point in the history
…nd use `type` (#18904)
  • Loading branch information
crazymanish committed Jun 22, 2021
1 parent 430fcb1 commit 8185b6a
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions fastlane/lib/fastlane/actions/github_api.rb
Expand Up @@ -92,15 +92,13 @@ def available_options
conflicting_options: [:api_bearer],
sensitive: true,
code_gen_sensitive: true,
is_string: true,
default_value: ENV["GITHUB_API_TOKEN"],
default_value_dynamic: true,
optional: true),
FastlaneCore::ConfigItem.new(key: :api_bearer,
env_name: "FL_GITHUB_API_BEARER",
sensitive: true,
code_gen_sensitive: true,
is_string: true,
description: "Use a Bearer authorization token. Usually generated by Github Apps, e.g. GitHub Actions GITHUB_TOKEN environment variable",
conflicting_options: [:api_token],
optional: true,
Expand All @@ -118,13 +116,12 @@ def available_options
FastlaneCore::ConfigItem.new(key: :body,
env_name: "FL_GITHUB_API_REQUEST_BODY",
description: "The request body in JSON or hash format",
is_string: false,
skip_type_validation: true, # allow Hash, Array
default_value: {},
optional: true),
FastlaneCore::ConfigItem.new(key: :raw_body,
env_name: "FL_GITHUB_API_REQUEST_RAW_BODY",
description: "The request body taken verbatim instead of as JSON, useful for file uploads",
is_string: true,
optional: true),
FastlaneCore::ConfigItem.new(key: :path,
env_name: "FL_GITHUB_API_PATH",
Expand All @@ -139,7 +136,7 @@ def available_options
end),
FastlaneCore::ConfigItem.new(key: :error_handlers,
description: "Optional error handling hash based on status code, or pass '*' to handle all errors",
is_string: false,
type: Hash,
default_value: {},
optional: true),
FastlaneCore::ConfigItem.new(key: :headers,
Expand Down

0 comments on commit 8185b6a

Please sign in to comment.