-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported Ruby versions and deprecate "sudo gem install" to system Ruby #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really welcome changes! Left some copy improvements, links and some feedback you might want to consider 😊
Thanks for this ❤️
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
@rogerluan Took all your suggestions and removed unnecessary whitespace🙂 Thank you for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!! Cheers 🎉
We'll then need to replace inline messages in fastlane itself as well🙂 |
Oh boy ☝️ 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much needed change! Thanks for making this 😊
I added two small change requests to change the vibe of the sentences a little bit so let me know what you think!
Feel free to merge this on your own when ready 😊
Co-authored-by: Josh “Now a dad so moving slower” Holtz <josh@rokkincat.com>
Co-authored-by: Josh “Now a dad so moving slower” Holtz <josh@rokkincat.com>
@joshdholtz Thank you very much for your review! I just applied your suggestions so, please ♻️ |
Requested changes were applied.
@ainame from Josh's last message I think he meant we can merge once those changes were applied 🎉 . netlify is failing to build this PR for some reason though 🤔 should we investigate that, or was it failing before as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Josh's suggestions were 💯 😁
Looks like the netlify issue is also present in master 😬 we can probably just merge this in then AFAIC |
Yeah, Netlify isn't super important but I should look into that 😊 I think I have access to that account somewhere 😬 But merge away! Click 👏 that 👏 button 👏 |
Ah sorry, I thought Josh requested change too. I'm going to merge this now and will work on the "sudo" instructions in code next 👍 |
Closes #1018
Last year Ruby 3.0 was released and I started working on Ruby 3.0 migration project lately. I realised that not a few people pick up Ruby 3.0 as their first Ruby version to install and get errors. fastlane/fastlane#17931
Right now if you try
gem install fastlane
with Ruby 3.0, it results in getting version "2.54.1", which is too old. We've gotten several issues due to that. To clarify supported versions, I updated the installation guide page.And also there is something bugging me always, which is recommending using "sudo". It's almost common sense among Ruby developers, which we should avoid using system's Ruby and should adopt some manager solution for local Ruby environment. So I tried updating that part as well.
I know Ruby environment for mobile app developers is not as important as for web developers but wanted to stop recommending system Ruby + "sudo" at least, which makes us even harder to track GitHub issues; e.g. fastlane/fastlane#15183 (comment)
In addition, Apple clearly mentioned that macOS won't include Ruby in future. We will need to admit this anyway.
https://developer.apple.com/documentation/macos-release-notes/macos-catalina-10_15-release-notes