Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: internationalization #80

Closed
wants to merge 1 commit into from
Closed

feat: internationalization #80

wants to merge 1 commit into from

Conversation

aradwann
Copy link
Contributor

@aradwann aradwann commented Mar 10, 2023 •
edited

Description

Related Issues

Check List

related to #32

@aradwann aradwann changed the title wrap all text labels in JSX by translate calls feat: internationalization Mar 10, 2023
@aradwann aradwann temporarily deployed to github-pages March 10, 2023 17:27 — with GitHub Actions Inactive
mcollina
mcollina requested changes Mar 11, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 in adding any sort of translation to our website. It would be quickly become out of date.

@aradwann
Copy link
Contributor Author

I'm -1 in adding any sort of translation to our website. It would be quickly become out of date.

I thought I'd experiment with it in this draft as it's mentioned in #32 ,but, I am not aware of the translation synchronization dynamics,
it's good that you pointed it out

@Fdawgs
Copy link
Member

Fdawgs commented Jun 30, 2023

I don't think there is a want/need for this, so the PR would potentially be closed?

@aradwann aradwann closed this Jul 1, 2023
@aradwann aradwann deleted the feat-internationalization branch July 1, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aradwann @Fdawgs @mcollina