fix: properly handle Express.js send payload #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, sweet! I opened up #222 for the type error - would be great to land it then rebase this PR to verify CI is happy (the unit tests passed, so I assume so 🙂) |
Uzlopak
approved these changes
Sep 9, 2022
|
@L2jLiga could you rebase? |
L2jLiga
force-pushed
the
fix/express-payload
branch
from
8b3ecf5
to
156812f
Compare
|
Yep, just pushed |
|
Hmm, updating in my project, and
I'm about to call it a week, but I'll do some more digging Monday (or this weekend if I'm bored) |
2 tasks
|
See fastify/fastify-express#47 (comment) for a reproduction |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took test from #155
Also reverted changes in
response.jsmade in #154tsdtests seems to fail on master tooChecklist
npm run testandnpm run benchmarkand the Code of conduct