Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make user-agent and content-type overwritable with undefined #216

Merged
merged 2 commits into from Aug 17, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 16, 2022

@budarin
I open this PR to see if the unit tests run.

Checklist

@budarin
Copy link

budarin commented Aug 16, 2022

Thanks!

This covers the necessary requirements 🚀

test/test.js Outdated Show resolved Hide resolved
@Uzlopak Uzlopak requested a review from Eomm August 16, 2022 19:30
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 16, 2022

Well it is based on your work. Lets see if the others agree

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c3aa66f into fastify:master Aug 17, 2022
@Uzlopak Uzlopak deleted the make-special-headers-undefinable branch August 17, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants