Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the default github token to the github-token input #264

Merged
merged 3 commits into from Sep 4, 2022

Conversation

smorimoto
Copy link
Contributor

As the title says...

Checklist

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@simoneb
Copy link
Collaborator

simoneb commented Aug 30, 2022

Are you sure that this works? I can't find anything in the docs suggesting that you can specify dynamic default values for action inputs. Do you have a sample repo showing that this works?

@climba03003
Copy link
Member

climba03003 commented Aug 30, 2022

I see similar approach on actions/checkout.

https://github.com/actions/checkout/blob/main/action.yml#L12-L24

@simoneb
Copy link
Collaborator

simoneb commented Aug 30, 2022

Ah that's pretty cool, too bad this is not in the docs!

@smorimoto can you please update the docs to reflect this?

@simoneb simoneb merged commit 33bd98d into fastify:main Sep 4, 2022
@smorimoto smorimoto deleted the pass-github-token-default branch September 4, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants