fix: check that the author is defined when comparing it with dependab… #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would reintroduce GHSA-v5vr-h3xq-8v6w (accidently closed) |
marco-ippolito
changed the title
marco-ippolito
changed the title
simoneb
reviewed
Aug 22, 2022
This would not. The intention is to consider a missing author as anybody who's not dependabot. |
simoneb
reviewed
Aug 23, 2022
test/action.test.js
Outdated
| author: { | ||
| login: 'not dependabot', | ||
| }, | ||
| author: undefined, |
There was a problem hiding this comment.
we need to test both cases, not just once. to avoid duplication of the whole test, just create an array with the two users and create the 2 tests in a loop
simoneb
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #259
Checklist
npm run testandnpm run benchmarkand the Code of conduct