Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Standardize getModuleVersionChanges return type #176

Merged
merged 3 commits into from Apr 11, 2022

Conversation

guilhermelimak
Copy link
Contributor

@guilhermelimak guilhermelimak commented Apr 11, 2022

Avoid returning false (which as far as I can see was not being used in any case) and always return an object.

Closes #172

Checklist

Avoid returning false (which as far as I can see was not being used in any case) and always return an object.
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we fix a bug, always add a unit test on that specific bug to prevent a regression and confirm that the change actually fixes it. Write a failing test which exposes the issue, then fix the issue and see the test succeeding.

@simoneb
Copy link
Collaborator

simoneb commented Apr 11, 2022

LGTM, good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 3.1.0: Error: Cannot use 'in' operator to search for '' in false
2 participants