test: add tests for error handling #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
climba03003
requested changes
May 6, 2024
| // In this test file numbered comments indicate the order statements are expected to execute | ||
|
|
||
| test('encapsulates an asynchronous error handler', async t => { | ||
| t.plan(4) |
There was a problem hiding this comment.
Suggested change
| t.plan(4) | |
| t.plan(3) |
Why t.plan is 4 but not 3?
I can see three t.equal only and none of the code path run twice.
|
@domdomegg would you also add a fix? |
|
Hi folk, it's been a while since I've looked at the fastify code, especially since #5222 which this is based off. I think I was wrong here, and I think #5445 does fix it. Think I've confused myself with misunderstanding some of the errors from the tap test runner 🤦, thank you @climba03003 for flagging this. Glad this is all finally sorted :) |
|
@domdomegg I think this PR still worth merging. Would you consoder re-open and fix the test plan? |
gurgunday
changed the title
gurgunday
approved these changes
May 14, 2024
climba03003
approved these changes
May 14, 2024
climba03003
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are failing tests to show that #5445 does not fix #5220
Checklist
npm run testandnpm run benchmarkand the Code of conduct