types: Use full pino API as Logger default

[matt-smarsh]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

Fixes #5382

[climba03003]

It's like changing the default is incompatible with the generic

[climba03003]

More discussion on #5244 and #4960

[mcollina]

This essentially reverts #2289 and #2289.

I guess we have some decisions to make on this one.

Things were separated to allow of other loggers to be passed in, but the generics are not really working well for this.

[matt-smarsh]

Oof, yeah. Just looking at test/types/hooks.test-d.ts would lead me to believe that the types for server.addHook() are now causing problems. I don't know the history of these interfaces well enough to understand why addHook is completely duplicating the FastifyInstance generics rather than just passing this. I'll keep playing around with things locally but I might not be able to solve this on my own.

[matt-smarsh]

I think the hook handlers can be simplified quite a bit by using infer and passing the entire fastify instance to them as a generic. Something like the following:

export interface onRequestHookHandler<
  Server extends FastifyInstance<any, any, any, any, any>,
> {
  (
    this: Server,
    request: Server extends FastifyInstance<any, infer RawRequest, any, any, any> ? RawRequest : never,
    reply: Server extends FastifyInstance<any, any, infer RawReply, any, any> ? RawReply : never,
    done: HookHandlerDoneFunction
  ): void;
}

Then using it would allow each hook to be simplified to:

  addHook<
    Fn extends onRequestHookHandler<this> | onRequestAsyncHookHandler<this> = onRequestHookHandler<this>
  >(
    name: 'onRequest',
    hook: Fn extends unknown ? Fn extends AsyncFunction ? onRequestAsyncHookHandler<this> : onRequestHookHandler<this> : Fn,
  ): this;

I don't know if this will break other areas but it would seem to help with preserving any user-defined custom interfaces.

D'oh, I can see now that while that works, the request and reply properties aren't supposed to be the Raw versions, but wrapped in with Fastify* equivalents. I think I'm at my knowledge limit with this one. Hopefully someone else can figure it out.