types: `reply.getSerializationFunction` can return `undefined` #5384

remidewitte · 2024-04-03T09:30:20Z

When the schema have not yet been compiled with reply.compileSerializationSchema, reply.getSerializationFunction can return undefined.

See :

fastify/lib/reply.js

Line 358 in c90ac14

serialize = this[kRouteContext][kReplyCacheSerializeFns]?.get(schemaOrStatus)

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

mcollina

lgtm

reply.getSerializationFunction can return undefined

30847f5

remidewitte changed the title ~~reply.getSerializationFunction can return undefined~~ types: reply.getSerializationFunction can return undefined Apr 3, 2024

mcollina approved these changes Apr 22, 2024

View reviewed changes

mcollina merged commit 20e3e35 into fastify:main Apr 29, 2024
39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

types: `reply.getSerializationFunction` can return `undefined` #5384

types: `reply.getSerializationFunction` can return `undefined` #5384

remidewitte commented Apr 3, 2024 •

edited

mcollina left a comment

types: reply.getSerializationFunction can return undefined #5384

types: reply.getSerializationFunction can return undefined #5384

Conversation

remidewitte commented Apr 3, 2024 • edited

Checklist

mcollina left a comment

Choose a reason for hiding this comment

types: `reply.getSerializationFunction` can return `undefined` #5384

types: `reply.getSerializationFunction` can return `undefined` #5384

remidewitte commented Apr 3, 2024 •

edited