Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config type in RouteShorthandOptions #5355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BrianValente
Copy link

Hello! This PR fixes #5322.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for types.

@BrianValente BrianValente changed the title Fix config type in RouteShorthandOptions fix: config type in RouteShorthandOptions Mar 21, 2024
@BrianValente BrianValente force-pushed the bugfix/custom-context-config-types branch from 28f8fec to dbfed76 Compare April 16, 2024 13:57
@BrianValente
Copy link
Author

@mcollina Sorry, but I couldn't find a way to test this. I'm not familiar with tsd, and the kind of test needed here is complex because it should encapsulate a type declaration just for the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionals in FastifyRequest based on ContextConfig broken since 4.19.0
2 participants