chore: onRegister reference instance in this #4972
Draft
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
For onClose avvio has to be patched. |
Eomm
added
semver-major
Eomm
previously approved these changes
Aug 14, 2023
| @@ -66,7 +66,9 @@ module.exports = function override (old, fn, opts) { | |||
| instance[kFourOhFour].arrange404(instance) | |||
| } | |||
|
|
|||
| for (const hook of instance[kHooks].onRegister) hook.call(this, instance, opts) | |||
There was a problem hiding this comment.
mmm this was the parent instance, while the instance was the new one
it does not change too much since we inherit all from the parent
There was a problem hiding this comment.
Maybe we'll need to adjust the documentation for that. As if the instance contains props that the parent does not, they might face weird situations
mcollina
dismissed stale reviews from Eomm and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct