(v3.x) perf: only check for isEssence once in RegExp for content-type-parser (#4481)

[climba03003]

Backport #4481

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[climba03003]

The error is about the generating certificate for https and http2 test.
No idea why it will fail suddenly.

[Uzlopak]

Well the tests fail because of node not passing the legacy flag to openssl or so.

[climba03003]

Well the tests fail because of node not passing the legacy flag to openssl or so.

Then, I curios why the same script pass on main?

[Uzlopak]

v4 uses the package self-cert. v3 uses pem.

The maintainer of pem already merged a fix long time ago into the repo, but never published on npm. In order to get it to work, we probably need to also replace pem with self-cert.

[climba03003]

main did use self-sign.
Hmm, maybe I mess up when checking different branches.

[jsumners]

main did use self-sign. Hmm, maybe I mess up when checking different branches.

The 3.x branch is still using pem --

fastify/package.json

Line 161 in 6053031

"pem": "^1.14.4",

#3711 should be backported to 3.x

[Eomm]

Is @fastify/core willing to bump a new v3 release?

[climba03003]

Is https://github.com/orgs/fastify/teams/core willing to bump a new v3 release?

We still maintaining 3.x branch as LTS.
Although, bugfix or security patch are the one focusing on but shouldn't block releasing new version if we have good changes.

[mcollina]

yes, I'll ship one with these fixes.

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.