Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix test skips for nodejs prereleases #4449

Merged
merged 1 commit into from Nov 29, 2022
Merged

chore: fix test skips for nodejs prereleases #4449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/close-pipelining.test.js
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ test('Should return 503 while closing - pipelining', async t => {
await instance.close()
})

const isV19plus = semver.satisfies(process.version, '>= v19.0.0')
const isV19plus = semver.gte(process.version, '19.0.0')
test('Should not return 503 while closing - pipelining - return503OnClosing: false, skip Node >= v19.x', { skip: isV19plus }, async t => {
const fastify = Fastify({
return503OnClosing: false,
Expand Down
2 changes: 1 addition & 1 deletion test/close.test.js
View file
Open in desktop
Expand Up @@ -203,7 +203,7 @@ test('Should return error while closing (callback) - injection', t => {
})
})

const isV19plus = semver.satisfies(process.version, '>= v19.0.0')
const isV19plus = semver.gte(process.version, '19.0.0')
t.test('Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x', { skip: isV19plus }, t => {
const fastify = Fastify({
return503OnClosing: false,
Expand Down