Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(reply): specify streams content-type #4337

Merged
merged 2 commits into from Oct 17, 2022

Conversation

D10f
Copy link
Contributor

@D10f D10f commented Oct 15, 2022

…pecified manually when sending back streams.

Checklist

…pecified manually when sending back streams.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 15, 2022
docs/Reference/Reply.md Outdated Show resolved Hide resolved
@D10f
Copy link
Contributor Author

D10f commented Oct 15, 2022

I added it based on the original issue that explains why streams should not have a content-type header by default: #3085

(...) fastify is being used as a proxy and is receiving an empty stream response.

To be honest I wasn't really sure if this should be mentioned, since this part of the documentation is already specific about stream responses. Also, there may be other cases where this applies and not only proxied responses? (not really sure about this either).

Perhaps is best to not mention this to avoid confusion and only point out that stream responses need the proper header.

@mcollina
Copy link
Member

I think so, avoid mentioning the proxy. Thanks!

@Fdawgs Fdawgs changed the title Updated Reply - Streams docs to reflect that content type should be s… docs(reply): specify streams content-type Oct 16, 2022
docs/Reference/Reply.md Outdated Show resolved Hide resolved
@Fdawgs Fdawgs requested a review from mcollina October 17, 2022 09:29
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 37c2426 into fastify:main Oct 17, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants