feat: parse request body for http SEARCH requests #4298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
Trying to migrate to fastify over from express, one of the bigger blockers we had is how we treat the SEARCH request. Basically handle it as a GET request with a body, which after digging into your codebase realized SEARCH body was not being parsed at all. The webDAV SEARCH specs specifically mention that SEARCH can have a body so not sure why this wasn't allowed in #3836 . Also noticed the tests were pretty non existent for the search methods, modified them to hopefully catch any accidental breakage in the future.