fix: custom validator should not mutate headers schema #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Sep 22, 2022
| @@ -327,7 +327,8 @@ function buildRouting (options) { | |||
| schemaController.setupValidator(this[kOptions]) | |||
| } | |||
| try { | |||
| compileSchemasForValidation(context, opts.validatorCompiler || schemaController.validatorCompiler) | |||
| const isCustom = typeof opts?.validatorCompiler === 'function' || schemaController.customValidatorCompiler | |||
| compileSchemasForValidation(context, opts.validatorCompiler || schemaController.validatorCompiler, isCustom) | |||
There was a problem hiding this comment.
Should we do the same for compileSchemasForSerialization for consistency?
There was a problem hiding this comment.
I have thought about it before. But serialization didn't mutate the schema and I would leave it for now.
The isCustomSerializerCompiler is added only because it maybe useful in future.
zrosenbauer
reviewed
Sep 22, 2022
zrosenbauer
approved these changes
Sep 23, 2022
Eomm
approved these changes
Sep 23, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not take any assumption that
objectis something we want and mutate theheadersschema.Instead, whenever the
userpass custom validator. All the responsibility should be given to the user and that library to handle.Fixes fastify/fastify-type-provider-typebox#42
Checklist
npm run testandnpm run benchmarkand the Code of conduct