Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce ci test when linting fails #4280

Merged
merged 2 commits into from Sep 16, 2022
Merged

ci: reduce ci test when linting fails #4280

merged 2 commits into from Sep 16, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Sep 15, 2022

Right now we run the test for the coverage check.

image

We could run them only after the linting

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Fdawgs Fdawgs changed the title chore: reduce ci test when linting fails ci: reduce ci test when linting fails Sep 16, 2022
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 185ba3c into main Sep 16, 2022
@mcollina mcollina deleted the Eomm-patch-1 branch September 16, 2022 07:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants