New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Lint eco system error #4275
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d2ecfd7
init
zrosenbauer ea87958
Update Ecosystem.md
zrosenbauer d76f52c
Update Ecosystem.md
zrosenbauer fd611aa
Add comment
zrosenbauer 37ac869
Merge branch 'lint-eco-system-error' of github.com:zrosenbauer/fastif…
zrosenbauer acea73b
move inside the script
zrosenbauer d449d8e
Fix issues, add annotiotations + summary
zrosenbauer 4ac4b32
reset file
zrosenbauer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whi this has been changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't clear on the intent, as the previous version should run on every branch
push
not namedmain
/master
which would mean it will run outside of a PR and 2x on a PR (push
+pull_request
). In the current version it only runs on PRs (which I believe is the desired state).In addition, the script will only work on PRs. If we want to support PRs and not PRs, I need to tweak the script to run differently depending on the context & we should probably have 2 workflows.
I also wouldn't understand if its not running on main/master why we'd ever believe its not running on a PR....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsumners hey what was intent behind
push
andpull_request
trigger?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in past, che
pull_request
event was not triggered when new commits wherepush
ed to the PR's branch.Thanks for the clarification
I think it is good with this lighter setup
cc/ @Fdawgs