Variadic listen signature allows string port #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Sep 12, 2022
| @@ -200,3 +200,26 @@ test('listen when firstArg is { path: string(pipe) } and with backlog and callba | |||
| t.equal(address, '\\\\.\\pipe\\testPipe3') | |||
| }) | |||
| }) | |||
|
|
|||
| test('listen accepts a port as string, and callback', t => { | |||
There was a problem hiding this comment.
is there a test that checks that random port still works fine?
There was a problem hiding this comment.
I've added this test
marco-ippolito
requested review from
jsumners and
simoneb
and removed request for
jsumners and
simoneb
simoneb
approved these changes
Sep 12, 2022
jsumners
approved these changes
Sep 12, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #4267
At the moment when using the variadic signature of
listenand passing theportas astring, theportis converted to0even though the signature allowsstringas type.With this PR it is possible to convert the
portfromstringtonumber, and only in case thestringcannot be parsed to a valid integer it converts it to0.Checklist
npm run testandnpm run benchmarkand the Code of conduct