New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(typescript): fix fastify/fastify#4241 #4247
Conversation
add note in typescript doc to prevent ts(2349) warning fastify#4241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
docs/Reference/TypeScript.md
Outdated
@@ -61,6 +61,9 @@ in a blank http Fastify server. | |||
*Note: Set `target` property in `tsconfig.json` to `es2017` or greater to avoid | |||
[FastifyDeprecation](https://github.com/fastify/fastify/issues/3284) warning.* | |||
|
|||
*Note 2: Set `moduleResolution` property in `tsconfig.json` to `Node` to avoid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should provide a clearer condition to the user.
Avoid using
"moduleResolution": "NodeNext"
intsconfig.json
with"type": "module"
inpackage.json
. This combination is currently not supported byfastify
typing system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
add note in typescript doc to prevent ts(2349) warning
#4241
Checklist
npm run test
andnpm run benchmark
and the Code of conduct