Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc about configuring pino-pretty with TypeScript #4243

Merged
merged 3 commits into from Sep 1, 2022

Conversation

giacomorebonato
Copy link
Contributor

#4184

I am using the configurations described in the change in TypeScript project and works without type errors.
Of course in TypeScript I am importing Fastify using ESM syntax to have typings properly working.

Please let me know if you would use a different strategy for picking a logging configuration, I personally like to use an object to map the logger configuration for each environment.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 1, 2022
@giacomorebonato giacomorebonato marked this pull request as ready for review September 1, 2022 10:28
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants