Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/migration-guide-v4): update content #4242

Merged
merged 8 commits into from Sep 1, 2022
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 1, 2022

This changes the following:

  • General tidy and restructure of sentences to improve clarity; removes waffle
  • Adds section regarding deprecation of variadic fastify.listen() method under the non-breaking changes header
  • Renames "Deprecation of app.use()" section to "Removed app.use()" to reflect that the function has been fully removed and not just deprecated
  • Updated example handlers to be inline with style used in "Getting-Started" guide

What the guide is still missing:

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 1, 2022
@Fdawgs Fdawgs linked an issue Sep 1, 2022 that may be closed by this pull request
2 tasks
@Fdawgs Fdawgs marked this pull request as ready for review September 1, 2022 09:37
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 2fd9182 into main Sep 1, 2022
@Uzlopak Uzlopak deleted the docs/migration-guide branch September 1, 2022 10:53
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill Migration-Guide-V4.md
3 participants