Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hasRoute #4238

Merged
merged 7 commits into from Sep 4, 2022
Merged

feat: add hasRoute #4238

merged 7 commits into from Sep 4, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 31, 2022 •
edited

Fixes #4215

Checklist

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 31, 2022

In which file belongs the documentation of this method?

@Uzlopak Uzlopak requested review from mcollina, Eomm and jsumners and removed request for mcollina August 31, 2022 12:57
@mcollina
Copy link
Member

https://github.com/fastify/fastify/blob/main/docs/Reference/Server.md

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 31, 2022

added documentation

mcollina
mcollina approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners requested changes Aug 31, 2022
View reviewed changes
docs/Reference/Server.md Outdated Show resolved Hide resolved
jsumners
jsumners requested changes Sep 1, 2022
View reviewed changes
docs/Reference/Server.md Outdated Show resolved Hide resolved
docs/Reference/Server.md Outdated Show resolved Hide resolved
@Fdawgs Fdawgs changed the title add hasRoute feat: add hasRoute Sep 3, 2022
jsumners
jsumners approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Uzlopak Uzlopak merged commit c05f261 into fastify:main Sep 4, 2022
@Uzlopak Uzlopak deleted the has-route branch September 4, 2022 13:21
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature to check if route already exists
3 participants
@Uzlopak @mcollina @jsumners