Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export RouteGenericInterface #4234

Merged
merged 4 commits into from Sep 7, 2022
Merged

chore: export RouteGenericInterface #4234

merged 4 commits into from Sep 7, 2022

Conversation

ChrisCrewdson
Copy link
Contributor

@ChrisCrewdson ChrisCrewdson commented Aug 30, 2022

This is a very small change just to re-export RouteGenericInterface which is needed by typescript 4.8.x for implementations of RouteHandlerMethod
I created an issue for this #4235 that will be solved by this PR.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Could you add a unit test for this?

@ChrisCrewdson
Copy link
Contributor Author

I am not sure if I can, since this is just about being able to access the type but I can try.

@mcollina
Copy link
Member

We use tsd for our types tests.

@ChrisCrewdson
Copy link
Contributor Author

Since this doesn't actually add a type, just re-exports it, I can't figure out how this fits as a test. The existing type just needs to be exposed.

@mcollina
Copy link
Member

mcollina commented Sep 6, 2022

@ChrisCrewdson
Copy link
Contributor Author

Hopefully this is what you are looking for. This is the simplest test case since all properties from the interface are optional.

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants