New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export RouteGenericInterface #4234
chore: export RouteGenericInterface #4234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Could you add a unit test for this? |
I am not sure if I can, since this is just about being able to access the type but I can try. |
We use tsd for our types tests. |
Since this doesn't actually add a type, just re-exports it, I can't figure out how this fits as a test. The existing type just needs to be exposed. |
import it in https://github.com/fastify/fastify/blob/main/test/types/fastify.test-d.ts#L12 add an |
Hopefully this is what you are looking for. This is the simplest test case since all properties from the interface are optional. |
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a very small change just to re-export RouteGenericInterface which is needed by typescript 4.8.x for implementations of RouteHandlerMethod
I created an issue for this #4235 that will be solved by this PR.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct