New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improved migration guide for onRoute #4233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you think it is misleading?
The solution can be chosen from either one, and now it is totally different meaning.
Ehm, because I tried. :) |
import Fastify from 'fastify'
import FP from 'fastify-plugin'
const fastify = Fastify()
fastify.register(FP(function(fastify, option, done) {
fastify.addHook('onRoute', function() {
console.log('onRoute')
})
done()
}))
fastify.register(function(fastify, option, done) {
fastify.get('/', () => 'hello')
done()
})
import Fastify from 'fastify'
import FP from 'fastify-plugin'
const fastify = Fastify()
await fastify.register(FP(function(fastify, option, done) {
fastify.addHook('onRoute', function() {
console.log('onRoute')
})
done()
}))
fastify.get('/', () => 'hello') |
PR contents and title updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR improves the migration guide to explicit how to define routes when
onRoute
is also used.