Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix outdated type definition in ValidationResult interface #4062

Closed
wants to merge 2 commits into from
Closed

fix: fix outdated type definition in ValidationResult interface #4062

wants to merge 2 commits into from

Conversation

micheleriva
Copy link

Hi there,
this commit fixes #4045. There was an outdated type reference inside of fastify.d.ts that caused a type mismatch with the AJV library.

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Jun 21, 2022
@micheleriva micheleriva changed the title fix: fix outdated type definition in ValidationResult interface (fastify#4045) fix: fix outdated type definition in ValidationResult interface Jun 21, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd to test our types

@RafaelGSS
Copy link
Member

Thanks for opening a PR! Can you please add a unit test? We use tsd to test our types

Looks like we don't maintain tests for ValidationResult so far. It would be a great addition.

Also, it would need to be updated as well: https://github.com/fastify/fastify/blob/9e21d2829ad611dd57aec22eccb202ed39cf4f6f/docs/Reference/TypeScript.md#fastifyvalidationresult.

@mcollina
Copy link
Member

why did you close the PR?

@micheleriva
Copy link
Author

@mcollina I've seen that there's another PR fixing this problem and wanted to avoid duplications 🙂

@mcollina
Copy link
Member

which one?

@RafaelGSS
Copy link
Member

which one?

#4070

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastify ValidationResult type and AJV v8 ErrorObject mismatch
3 participants