add generic logger to route handler & FastifyRequest

[MarcoLeko]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

Initiated by this bug: #3775
I created a PR to fix the typings for the routeHandlers by using the FastifyRequest with a generic logger type.
As in the docs mentioned: https://www.fastify.io/docs/latest/Reference/Logging/#logging

You can also supply your own logger instance. Instead of passing configuration options, pass the instance. The logger you supply must conform to the Pino interface; that is, it must have the following methods: info, error, debug, fatal, warn, trace, child.

However with the implemented type definitions it is not possible to use a custom LoggerInstance as the log property was only restricted to be of type FastifyLoggerInstance and no generic.

This is somewhat of an urgent bugfix from our side as it blocks our development and migration from express to fastify. This is also the reason why we set the PR against this branch as we hope to see the fix already in version 3.x. and help other developers as well.

[mcollina]

lgtm

[mcollina]

cc @kibertoad @fox1t @Eomm could you review?

[fox1t]

This should be a non-breaking change. Kudos

[mcollina]

Can you please keep targeting main? If the change is backportable as-is the backport action would do its job, otherwise you can follow-up with another PR. Thanks.

[MarcoLeko]

Can you please keep targeting main? If the change is backportable as-is the backport action would do its job, otherwise you can follow-up with another PR. Thanks.

Hello @mcollina , since I branched out of 3v.x, I unfurtunately had to deal with huge merge conflicts. Furthermore seems that the FastifyRequest has a lot more extendable properties than in v3.x which effects also several RouteHandlers.

This is why I would recommend to apply these changes here seperately in 3v.x and I could offer you to make a completely different PR in the weekend (this time branching out from main branch) and target the main branch

[mcollina]

This should not land on v3.x until there is a matching PR for main.

[mcollina]

The types in v4 are significantly more enchanced.

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.