Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix new standard linting #3682

Merged
merged 2 commits into from Feb 6, 2022
Merged

style: fix new standard linting #3682

merged 2 commits into from Feb 6, 2022

Conversation

theoludwig
Copy link
Contributor

@theoludwig theoludwig commented Feb 6, 2022

This PR update standard to the next version (v17) coming soon and fixes linting issues (using standard --fix).
This allows having the test-external of standard passing for fastify/fastify, before releasing to stable, we ensure that the ecosystem can easily upgrade without issues.

Related: standard/standard#1777

This new version includes:

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 533b6d8 into fastify:main Feb 6, 2022
@theoludwig
Copy link
Contributor Author

theoludwig commented Feb 6, 2022

Hmm 🤔

It seems like CI is failing on main branch.
Do you need some help to fix it?

EDIT: It fails, because it uses Node.js v10, but standard now requires Node.js >= 12.22.0.

@theoludwig theoludwig deleted the style/fix-standard-linting branch February 6, 2022 20:35
@renovate renovate bot mentioned this pull request May 1, 2022
1 task
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants