Serialization errors will be send to errorHandler #3674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that fastify sometimes can throw errors not caught by
errorHandler
and it's difficult to understand where it comes from.Reduced Example you can find in the committed test:
Response schema with required field throws an error from
fast-json-stringify
when a required field is not found.So I decided that it will be ok idea to send the captured error to
errorHandler
like validation error, and add a sign that the error comes from serialization.But here I need your advice on how to envelop error propely.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct