Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept-version on default route #3630

Merged
merged 4 commits into from Jan 17, 2022
Merged

fix: accept-version on default route #3630

merged 4 commits into from Jan 17, 2022

Conversation

climba03003
Copy link
Member

Fixes #3625

I think as a fast solution and not falling into the version constraint check in find-my-way. We can use a symbol to temporary store the header and revert it after find-my-way pick up the route.

Checklist

@climba03003 climba03003 added the benchmark Label to run benchmark against PR and main branch label Jan 17, 2022
@github-actions
Copy link

Node: 12
PR: [1] 1117k requests in 30.06s, 209 MB read
MAIN: [1] 1171k requests in 30.09s, 219 MB read


Node: 14
PR: [1] 1002k requests in 30.06s, 187 MB read
MAIN: [1] 1065k requests in 30.07s, 199 MB read


Node: 16
PR: [1] 1102k requests in 30.07s, 206 MB read
MAIN: [1] 1102k requests in 30.06s, 206 MB read

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jan 17, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 4d87089 into fastify:main Jan 17, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept-Version is always undefined
4 participants