Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prototype poisoning doc #3609

Merged
merged 2 commits into from Jan 11, 2022
Merged

Add prototype poisoning doc #3609

merged 2 commits into from Jan 11, 2022

Conversation

jsumners
Copy link
Member

Resolves issue #3003.

cc: @hueniverse

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 10, 2022
RafaelGSS
RafaelGSS approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

luisorbaiceta
luisorbaiceta requested changes Jan 11, 2022
View reviewed changes
docs/Guides/Prototype-Poisoning.md Outdated Show resolved Hide resolved
luisorbaiceta
luisorbaiceta approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@luisorbaiceta luisorbaiceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

climba03003
climba03003 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hueniverse
Copy link

I think you should remove all the non-technical relevant stuff and instead of the strong attribution, simply replace it with "Based on the article ... by Eran Hammer". I'm giving you full permission to use this text as you find useful. Don't be shy to change it.

mcollina
mcollina approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners mentioned this pull request Jan 11, 2022
Closed
@jsumners
Copy link
Member Author

I think you should remove all the non-technical relevant stuff and instead of the strong attribution, simply replace it with "Based on the article ... by Eran Hammer". I'm giving you full permission to use this text as you find useful. Don't be shy to change it.

Thank you. I appreciate the suggestion. Right now, I do not have the time to massage the language like that. I have created a new issue to address it in the future.

@jsumners jsumners merged commit d7a23a0 into main Jan 11, 2022
@jsumners jsumners deleted the issue-3003 branch January 11, 2022 13:29
@rluvaton
Copy link
Contributor

rluvaton commented Jan 19, 2022 •
edited

Just wanted to say it was delightful to read the Prototype Poisoning page, thank you 😀

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@luisorbaiceta luisorbaiceta luisorbaiceta approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jsumners @hueniverse @rluvaton @mcollina @climba03003 @RafaelGSS @luisorbaiceta