Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: replace fastify.decorate arrow functions with function expressions #3577

Merged
merged 1 commit into from Dec 28, 2021
Merged

Documentation: replace fastify.decorate arrow functions with function expressions #3577

merged 1 commit into from Dec 28, 2021

Conversation

onosendi
Copy link
Contributor

This is a change I disagreed with. I will likely revert all such declarations to full function declarations as I update the documentation. In this specific case, it is clearly wrong. A PR to fix this one would be quite welcome. - @jsumners

Replace arrow functions with function expressions in the Plugins documentation.

Checklist

  • [x ] documentation is changed or added

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2021
@onosendi onosendi changed the title Replace fastify.decorate arrow functions with function expressions Documentation: replace fastify.decorate arrow functions with function expressions Dec 28, 2021
luisorbaiceta
luisorbaiceta approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@luisorbaiceta luisorbaiceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0814d23 into fastify:main Dec 28, 2021
jsumners
jsumners reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

@luisorbaiceta luisorbaiceta luisorbaiceta approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onosendi @mcollina @jsumners @luisorbaiceta