New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(reply): specify streams content-type #4337
Conversation
…pecified manually when sending back streams.
I added it based on the original issue that explains why streams should not have a content-type header by default: #3085
To be honest I wasn't really sure if this should be mentioned, since this part of the documentation is already specific about stream responses. Also, there may be other cases where this applies and not only proxied responses? (not really sure about this either). Perhaps is best to not mention this to avoid confusion and only point out that stream responses need the proper header. |
I think so, avoid mentioning the proxy. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…pecified manually when sending back streams.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct