Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3648 - URL must be a string #3653

Merged
merged 12 commits into from Jan 25, 2022
Merged

Fixes #3648 - URL must be a string #3653

merged 12 commits into from Jan 25, 2022

Conversation

VigneshMurugan
Copy link
Contributor

@VigneshMurugan VigneshMurugan commented Jan 24, 2022 •
edited

Checklist

@VigneshMurugan VigneshMurugan changed the title Fixed #3648 - URL must be a string Fixes #3648 - URL must be a string Jan 24, 2022
@VigneshMurugan VigneshMurugan changed the title Fixes #3648 - URL must be a string Fixes #3648 - URL must be a string - DRAFT Jan 24, 2022
@jsumners jsumners marked this pull request as draft January 24, 2022 18:21
@jsumners jsumners changed the title Fixes #3648 - URL must be a string - DRAFT Fixes #3648 - URL must be a string Jan 24, 2022
@VigneshMurugan VigneshMurugan marked this pull request as ready for review January 24, 2022 18:24
@VigneshMurugan
Copy link
Contributor Author

@mcollina @jsumners I am not sure how reviews work in here. Should i tag someone or do you all(maintainers) pick the PRs on priority and approve it.

Thanks

Eomm
Eomm reviewed Jan 24, 2022
View reviewed changes
lib/route.js Outdated Show resolved Hide resolved
Vignesh and others added 2 commits January 25, 2022 01:15
@Eomm
Update lib/route.js
9619753 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Update route.test.js
2928c1d
jsumners
jsumners reviewed Jan 24, 2022
View reviewed changes
lib/route.js Outdated Show resolved Hide resolved
@climba03003 climba03003 linked an issue Jan 24, 2022 that may be closed by this pull request
should throw for non-string route URL #3648
Closed
2 tasks
mcollina
mcollina reviewed Jan 25, 2022
View reviewed changes
lib/route.js Outdated Show resolved Hide resolved
jsumners
jsumners approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mcollina
mcollina approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 25147fe into fastify:main Jan 25, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should throw for non-string route URL
4 participants
@VigneshMurugan @mcollina @jsumners @Eomm