New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should throw for non-string route URL #3648
Labels
Comments
Definitely! |
mcollina
added
good first issue
Good for newcomers
enhancement
v4.x
Issue or pr related to Fastify v4
semver-major
Issue or PR that should land as semver major
labels
Jan 23, 2022
I think it's a semver-patch. It currently does not work, but does so without any warning. |
mcollina
removed
semver-major
Issue or PR that should land as semver major
v4.x
Issue or pr related to Fastify v4
labels
Jan 23, 2022
VigneshMurugan
added a commit
to VigneshMurugan/fastify
that referenced
this issue
Jan 24, 2022
VigneshMurugan
added a commit
to VigneshMurugan/fastify
that referenced
this issue
Jan 24, 2022
This reverts commit c5cd59f.
VigneshMurugan
added a commit
to VigneshMurugan/fastify
that referenced
this issue
Jan 24, 2022
4 tasks
mcollina
pushed a commit
that referenced
this issue
Jan 25, 2022
* Fixed #3648 - URL must be a string * Revert "Fixed #3648 - URL must be a string" This reverts commit c5cd59f. * Fixed #3648 - URL must be a string * Fixed GitHub Linter Error * Fixed GitHub Linter Error * Fixed GitHub Linter Error * Fixed GitHub Linter Error * Update lib/route.js Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> * Update route.test.js * Addressed Review comments - Used Error codes. Removed unecessary url existence check * Removed unecessary logger statement Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Prerequisites
Issue
This snippet starts correctly:
There is one error: the regExp on the route's URL.
In this case, I think we should throw an error.
Note that find-my-way is receiving a string because we are composing its route input checking the
prefix
etc..Do you agree?
The text was updated successfully, but these errors were encountered: