fix: remove-label job uses the wrong repo (#5415)

* fix: remove label gets passed the wrong repo information * add cithm too * use github event * add permissions * use list form
fastify · Apr 21, 2024 · c47b033 · c47b033
1 parent 35a6b99
commit c47b033
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/.github/workflows/benchmark-parser.yml b/.github/workflows/benchmark-parser.yml
@@ -64,7 +64,8 @@ jobs:
           echo 'EOF' >> $GITHUB_OUTPUT
 
   output-benchmark:
-    needs: [benchmark]
+    needs:
+      - benchmark
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write

diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -64,7 +64,8 @@ jobs:
           echo 'EOF' >> $GITHUB_OUTPUT
 
   output-benchmark:
-    needs: [benchmark]
+    needs:
+      - benchmark
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
@@ -96,13 +97,15 @@ jobs:
       - benchmark
       - output-benchmark
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
     steps:
       - name: Remove benchmark label
         uses: octokit/request-action@v2.x
         id: remove-label
         with:
           route: DELETE /repos/{repo}/issues/{issue_number}/labels/{name}
-          repo: ${{ github.event.pull_request.head.repo.full_name }}
+          repo: ${{ github.repository }}
           issue_number: ${{ github.event.pull_request.number }}
           name: benchmark
         env:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -87,13 +87,15 @@ jobs:
           npm run lint
 
   coverage-nix:
-    needs: lint
+    needs:
+      - lint
     permissions:
       contents: read
     uses: ./.github/workflows/coverage-nix.yml
 
   coverage-win:
-    needs: lint
+    needs:
+      - lint
     permissions:
       contents: read
     uses: ./.github/workflows/coverage-win.yml

diff --git a/.github/workflows/citgm.yml b/.github/workflows/citgm.yml
@@ -90,13 +90,15 @@ jobs:
       - core-plugins
     continue-on-error: true
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
     steps:
       - name: Remove citgm-core-plugins label
         uses: octokit/request-action@v2.x
         id: remove-label
         with:
           route: DELETE /repos/{repo}/issues/{issue_number}/labels/{name}
-          repo: ${{ github.event.pull_request.head.repo.full_name }}
+          repo: ${{ github.repository }}
           issue_number: ${{ github.event.pull_request.number }}
           name: citgm-core-plugins
         env: