perf: replace parseInt with Number (#4289)

fastify · Sep 19, 2022 · 9d9d62c · 9d9d62c
1 parent 4109b03
commit 9d9d62c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/contentTypeParser.js b/lib/contentTypeParser.js
@@ -189,7 +189,7 @@ function rawBody (request, reply, options, parser, done) {
   const limit = options.limit === null ? parser.bodyLimit : options.limit
   const contentLength = request.headers['content-length'] === undefined
     ? NaN
-    : Number.parseInt(request.headers['content-length'], 10)
+    : Number(request.headers['content-length'])
 
   if (contentLength > limit) {
     reply.send(new FST_ERR_CTP_BODY_TOO_LARGE())

diff --git a/lib/reply.js b/lib/reply.js
@@ -292,7 +292,7 @@ Reply.prototype.removeTrailer = function (key) {
 }
 
 Reply.prototype.code = function (code) {
-  const intValue = parseInt(code)
+  const intValue = Number(code)
   if (isNaN(intValue) || intValue < 100 || intValue > 599) {
     throw new FST_ERR_BAD_STATUS_CODE(code || String(code))
   }
@@ -562,7 +562,7 @@ function onSendEnd (reply, payload) {
     const contentLength = reply[kReplyHeaders]['content-length']
     if (!contentLength ||
         (req.raw.method !== 'HEAD' &&
-         parseInt(contentLength, 10) !== Buffer.byteLength(payload)
+         Number(contentLength) !== Buffer.byteLength(payload)
         )
     ) {
       reply[kReplyHeaders]['content-length'] = '' + Buffer.byteLength(payload)

diff --git a/lib/server.js b/lib/server.js
@@ -331,7 +331,7 @@ function normalizeListenArgs (args) {
 }
 
 function normalizePort (firstArg) {
-  const port = parseInt(firstArg, 10)
+  const port = Number(firstArg)
   return port >= 0 && !Number.isNaN(port) ? port : 0
 }
 

diff --git a/test/internals/reply-serialize.test.js b/test/internals/reply-serialize.test.js
@@ -231,7 +231,7 @@ test('Reply#getSerializationFunction', t => {
         (req, reply) => {
           const { id } = req.params
 
-          if (parseInt(id) === 1) {
+          if (Number(id) === 1) {
             const serialize4xx = reply.getSerializationFunction('4xx')
             const serialize201 = reply.getSerializationFunction(201)
             const serializeUndefined = reply.getSerializationFunction(undefined)
@@ -308,7 +308,7 @@ test('Reply#getSerializationFunction', t => {
         (req, reply) => {
           const { id } = req.params
 
-          if (parseInt(id) === 1) {
+          if (Number(id) === 1) {
             const serialize = reply.compileSerializationSchema(schemaObj)
 
             t.type(serialize, Function)