feat: make reply.redirect() and reply.callNotFound() return reply (#4037

)

Signed-off-by: Matteo Collina <hello@matteocollina.com>

lib/reply.js

@@ -331,10 +331,12 @@ Reply.prototype.redirect = function (code, url) {
   }
 
   this.header('location', url).code(code).send()
+  return this
 }
 
 Reply.prototype.callNotFound = function () {
   notFound(this)
+  return this
 }
 
 Reply.prototype.getResponseTime = function () {

test/404s.test.js

@@ -1320,7 +1320,7 @@ test('preHandler option for setNotFoundHandler', t => {
 
   // https://github.com/fastify/fastify/issues/2229
   t.test('preHandler hook in setNotFoundHandler should be called when callNotFound', { timeout: 40000 }, t => {
-    t.plan(2)
+    t.plan(3)
     const fastify = Fastify()
 
     fastify.setNotFoundHandler({
@@ -1333,7 +1333,7 @@ test('preHandler option for setNotFoundHandler', t => {
     })
 
     fastify.post('/', function (req, reply) {
-      reply.callNotFound()
+      t.equal(reply.callNotFound(), reply)
     })
 
     fastify.inject({

test/internals/reply.test.js

@@ -233,6 +233,10 @@ test('within an instance', t => {
     reply.redirect('/')
   })
 
+  fastify.get('/redirect-async', async function (req, reply) {
+    return reply.redirect('/')
+  })
+
   fastify.get('/redirect-code', function (req, reply) {
     reply.redirect(301, '/')
   })
@@ -412,6 +416,14 @@ test('within an instance', t => {
       })
     })
 
+    test('redirect with async function to `/` - 10', t => {
+      t.plan(1)
+
+      http.get('http://localhost:' + fastify.server.address().port + '/redirect-async', function (response) {
+        t.equal(response.statusCode, 302)
+      })
+    })
+
     t.end()
   })
 })