Retain path when using fallback precompressed path #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no brotli-encoded asset and instead only a gzip-encoded one, the code first tries to serve the brotli-encoded form and then falls back on the gzip-encoded one. When doing so, however, it uses a path name that has been overwritten which leads to the wrong file being served. For instance, if a request is for `/dir/`, then `pathname` will first be changed to `index.html`. On the retry, `index.html` will be used as the base pathname and thus `/index.html` will be served instead of `/dir/index.html`.
gurgunday
approved these changes
Mar 29, 2024
|
@colatkinson I will release a patch in a bit, this seems important |
|
@gurgunday Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no brotli-encoded asset and instead only a gzip-encoded one, the code first tries to serve the brotli-encoded form and then falls back on the gzip-encoded one. When doing so, however, it uses a path name that has been overwritten which leads to the wrong file being served.
For instance, if a request is for
/dir/, thenpathnamewill first be changed toindex.html. On the retry,index.htmlwill be used as the base pathname and thus/index.htmlwill be served instead of/dir/index.html.Unsure if there's a better way to fix. However, I'm hopeful that if there's a cleaner way, the test will at least demonstrate the bug more clearly.
Checklist
npm run testandnpm run benchmarkand the Code of conduct