Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle NotFoundError(#218) #219

Closed
wants to merge 1 commit into from
Closed

fix: handle NotFoundError(#218) #219

wants to merge 1 commit into from

Conversation

BlackGlory
Copy link
Contributor

@BlackGlory BlackGlory commented Jul 8, 2021

#218

Checklist

@BlackGlory BlackGlory changed the title fix: handle NotFoundError(https://github.com/fastify/fastify-static/issues/218) fix: handle NotFoundError(#218) Jul 8, 2021
@Eomm
Copy link
Member

Eomm commented Jul 8, 2021

Could you add a test to avoid regressions?
Thank you

@BlackGlory
Copy link
Contributor Author

The testing of this project is too confusing for me, I can't do anything about it.
I hope someone can find a way to correctly locate this error from the example I gave, and then write a proper test.

@Eomm
Copy link
Member

Eomm commented Aug 5, 2021

Superseded by #225

@Eomm Eomm closed this Aug 5, 2021
@BlackGlory BlackGlory deleted the patch branch August 5, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants