Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call 404 handler if requested path is a dotfile #225

Merged
merged 2 commits into from Aug 5, 2021

Conversation

GormanFletcher
Copy link
Contributor

This closes #218 and #219. The registered notFoundHandler wasn't being called when the request path included dotfiles with send's default configuration of ignoring dotfiles. Previous behavior resulted in fastify printing an exception and leaving the request hanging.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit fa907a0 into fastify:master Aug 5, 2021
@Eomm Eomm mentioned this pull request Aug 5, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the file is not found, Fastify's 404 handler is not triggered
4 participants