Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): replace eslint-plugin-node with eslint-plugin-n #374

Merged
merged 2 commits into from Jul 22, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jul 22, 2022

Checklist

@Fdawgs Fdawgs requested a review from climba03003 July 22, 2022 14:15
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@climba03003
Copy link
Member

For eslint-config-standard-with-typescript, the below is what it required.

"@typescript-eslint/eslint-plugin": "^5.30.7",
"@typescript-eslint/parser": "5.30.7",
"eslint": "^8.20.0",
"eslint-config-standard-with-typescript": "^22.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-n": "^15.2.4",
"eslint-plugin-promise": "^6.0.0",

@Fdawgs
Copy link
Member Author

Fdawgs commented Jul 22, 2022

For eslint-config-standard-with-typescript, the below is what it required.

"@typescript-eslint/eslint-plugin": "^5.30.7",
"@typescript-eslint/parser": "5.30.7",
"eslint": "^8.20.0",
"eslint-config-standard-with-typescript": "^22.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-n": "^15.2.4",
"eslint-plugin-promise": "^6.0.0",

You've lost me there @climba03003, are you saying I should get rid of the other configs and plugins?

@climba03003
Copy link
Member

You've lost me there @climba03003, are you saying I should get rid of the other configs and plugins?

Yes, basically it should remove all those packages. Since it didn't use in anywhere.

@Fdawgs
Copy link
Member Author

Fdawgs commented Jul 22, 2022

You've lost me there @climba03003, are you saying I should get rid of the other configs and plugins?

Yes, basically it should remove all those packages. Since it didn't use in anywhere.

Cool beans, done in 047887e

@climba03003 climba03003 merged commit bf4359c into master Jul 22, 2022
@Fdawgs Fdawgs deleted the chore/deps-dev branch July 22, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants