refactor: remove const validation branch #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the const stuff now basically reverted? |
Not completely. It works properly. The code I accidentally added is unreachable because the proper check exists. Line 778 in 8997bf1 Here the code was removed: Here it was accidentally added: |
|
can you resolve the conflicts? |
ivan-tymoshenko
force-pushed
the
remove-const-validation-branch
branch
from
90d662b
to
94ae012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad, I've badly rebased #504 on #511. It doesn't fail because it is an unreachable code now.