Infer type schema #514
Merged
Infer type schema #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added type inference * Test cases with tsd * Allow manual inference
climba03003
reviewed
Aug 29, 2022
|
@climba03003 I agree. The implementation should work across json schema libraries. I detailed why a generic only extending object is better for cross library support here. #509 (comment) Putting the onus on the user to provide the correct type is a good trade off for flexibility. |
So if everyone is ok I can update the PR |
|
Nice. Thanks @DanieleFedeli I appreciate you |
climba03003
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
This PR is linked to #509 and aims to propagate schema type to the final function
This comment showed the outcome.