fix: toString method validation check #513
Merged
+40
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #492
I think that this is a good opportunity to discuss this check. It says that if an object has a defined custom
toString
method, we should validate it as a string. There are two points why I think this is a bad check.We don't coerce types during type validation because, otherwise, everything can be coerced to the string. Numbers and booleans also have the toString method, but we don't count them as a string type.
Ajv also does not use type coercion during schema validation, so the
toString
method won't be checked if you have anyOf/oneOf instead of a type array.I want to drop this check in some major release of FJS/Fastify. I would like to heat your thoughts about it.