Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for issue #388 #496

Merged
merged 1 commit into from Jul 30, 2022
Merged

test: add test for issue #388 #496

merged 1 commit into from Jul 30, 2022

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented Jul 30, 2022 •
edited

Checklist

Close #388

#388 was fixed in one of the refactoring PR. This PR adds a test for it.

mcollina
mcollina approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7af554a into master Jul 30, 2022
@Fdawgs Fdawgs deleted the add-test-for-issue-388 branch July 31, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid JSON Schema not working for null-able response
2 participants
@ivan-tymoshenko @mcollina